Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added WilliamFiset link under dsa youtube #709

Merged
merged 5 commits into from
May 26, 2023

Conversation

azmi-nabeel
Copy link
Contributor

Fixes Issue

Closes #707

Changes proposed

Added link to WilliamFiset Youtube channel to dsa subcategory under youtube category.

Screenshots

Screenshot 2023-05-24 184658

Note to reviewers

Please review my PR.
Thank you.

@vercel
Copy link

vercel bot commented May 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 11:30am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello azmi-nabeel, thanks for rising a Pull request, your contribution is valuable to us. The maintainers will review this Pull Request and provide feedback as soon as possible. Keep the great work up!

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove unnecessary spaces

@rupali-codes rupali-codes added goal: new-link Addition of new links related contributions gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) labels May 24, 2023
Removed unnecessary spaces.
@azmi-nabeel
Copy link
Contributor Author

I have made the suggested changes.

@azmi-nabeel azmi-nabeel requested a review from rupali-codes May 24, 2023 16:46
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @azmi-nabeel! :) I pointed out a proofreading error in my inline comment. In the future, consider running your descriptions through Grammarly or Spellcheck before making a pull request. Other than that, you're off to a great start! :)

Commit for the suggested change fixing the proofreading error.

Co-authored-by: Christine Belzie <105683440+CBID2@users.noreply.github.com>
@azmi-nabeel
Copy link
Contributor Author

Will make sure to proofread before making PRs next time onwards.👍

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @azmi-nabeel! 😄 LGTM! 😄

@CBID2
Copy link
Collaborator

CBID2 commented May 25, 2023

@rupali-codes, we're going to need your force push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-link Addition of new links related contributions gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Add] <Add WilliamFiset Channel link to Youtube/Data Structures>
3 participants