Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read more button added when text overflow on card #693

Conversation

Isha988
Copy link
Contributor

@Isha988 Isha988 commented May 23, 2023

Fixes Issue

closes #671
fixes #671

Changes proposed

Read more button is added for the card when the text over flow

Screenshots

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Isha988, thanks for rising a Pull request, your contribution is valuable to us. The maintainers will review this Pull Request and provide feedback as soon as possible. Keep the great work up!

@vercel
Copy link

vercel bot commented May 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 7:32am

@CBID2 CBID2 added goal: new-feature New feature or request good first issue Good for newcomers frontend labels May 23, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :) LGTM! :)

@CBID2 CBID2 requested a review from rupali-codes May 23, 2023 21:05
@Isha988
Copy link
Contributor Author

Isha988 commented May 24, 2023

Looks good to me! :) LGTM! :)

Just a gentle reminder of adding gssoc label if it is also required in pr.

@CBID2 CBID2 added the gssoc GirlScript Summer of Code participants label May 24, 2023
@rupali-codes rupali-codes added the level2 Modifying an existing feature label May 24, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Isha988! It looks great! :) I'm going to wait for @rupali-codes to respond & then I’ll review your PR again.

Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @Isha988! 😄 LGTM! 😄

Read more button text updated

Co-authored-by: Rupali Haldiya <78981177+rupali-codes@users.noreply.github.com>
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, tysm :)

@rupali-codes rupali-codes merged commit da5b83c into rupali-codes:main May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal: new-feature New feature or request good first issue Good for newcomers gssoc GirlScript Summer of Code participants level2 Modifying an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add 'read more' button when text overflows on the card
3 participants