Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update guidelines for making issues and commits #553

Merged
merged 13 commits into from
May 19, 2023

Conversation

rupali-codes
Copy link
Owner

Added some rules for creating issues and also for writing commit messages

@vercel
Copy link

vercel bot commented May 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 8:04pm

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello rupali-codes, thanks for rising a Pull request, your contribution is valuable to us. The maintainers will review this Pull Request and provide feedback as soon as possible. Keep the great work up!

@rupali-codes rupali-codes requested a review from CBID2 May 18, 2023 19:10
CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Christine Belzie <105683440+CBID2@users.noreply.github.com>
Co-authored-by: Christine Belzie <105683440+CBID2@users.noreply.github.com>
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rupali-codes! :) This is a great update! :) I left some suggestions on how to improve your explanations! :)

Co-authored-by: Christine Belzie <105683440+CBID2@users.noreply.github.com>
Co-authored-by: Christine Belzie <105683440+CBID2@users.noreply.github.com>
Co-authored-by: Christine Belzie <105683440+CBID2@users.noreply.github.com>
Co-authored-by: Christine Belzie <105683440+CBID2@users.noreply.github.com>
@rupali-codes
Copy link
Owner Author

hey @CBID2, i have made all the changes

@rupali-codes rupali-codes requested a review from CBID2 May 19, 2023 07:53
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rupali-codes! I edited the Pull Request section. Check them out and see what you think.

@rupali-codes
Copy link
Owner Author

Hey @rupali-codes! I edited the Pull Request section. Check them out and see what you think.

Where

@rupali-codes
Copy link
Owner Author

@CBID2 could you please review once again so i can merge the PR

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Owner Author

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @CBID2 i'm merging this PR as the event has started, we would need it keep it updated, wil add some extra rules in a sperate PR

@rupali-codes rupali-codes merged commit dbbde0f into main May 19, 2023
@CBID2
Copy link
Collaborator

CBID2 commented May 19, 2023

Hey @CBID2 i'm merging this PR as the event has started, we would need it keep it updated, wil add some extra rules in a sperate PR

Ok that's fine

@rupali-codes rupali-codes deleted the update-guidelines branch May 20, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants