Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort link cards #394

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Sort link cards #394

merged 1 commit into from
Apr 6, 2023

Conversation

OscarFMdev
Copy link
Contributor

Fixes Issue

Closes #393
This PR fixes the Sort Link cards issue

Changes proposed

+ cards.sort((a: IData, b: IData) => {
+    if (a.name < b.name) return -1;
+    if (a.name > b.name) return 1;
+    return 0;
+ });

Screenshots

Before

Screenshot 2023-04-05 at 12 07 02

After

Screenshot 2023-04-05 at 12 06 13

Note to reviewers

Thank you for reviewing my code!

@vercel
Copy link

vercel bot commented Apr 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 6:29pm

@OscarFMdev OscarFMdev mentioned this pull request Apr 5, 2023
Closed
rupali-codes
rupali-codes approved these changes Apr 6, 2023
View reviewed changes
Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect, thank you

@rupali-codes rupali-codes merged commit f1d4772 into rupali-codes:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rupali-codes rupali-codes rupali-codes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CHORE] Sort Link cards
2 participants
@OscarFMdev @rupali-codes