Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redirect to the corresponding section based on options in empty page screen #1875

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

Ameya02
Copy link
Contributor

@Ameya02 Ameya02 commented Oct 7, 2023

Fixes Issue

Closes #1735

Changes proposed

Added Link to wrap over the Typewriter component to redirect to the particular section page when click on the text
Removed autostart and loop as it causes the text to repeat twice

Screenshots

linkshub

Note to reviewers

@vercel
Copy link

vercel bot commented Oct 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2023 6:38am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Ameya02, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

Copy link
Collaborator

@Anmol-Baranwal Anmol-Baranwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me.

@Ameya02 Well done!

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously, the typewriter was clearing the subcategory letter-by-letter but now its clearing it all together, can we fix this?

@rupali-codes rupali-codes added priority: low Addition of new links/categories or doing any small task (e.g fixing typos) hacktoberfest hacktoberfest2023 hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest chore Might take time to finish labels Oct 7, 2023
@Ameya02
Copy link
Contributor Author

Ameya02 commented Oct 7, 2023

So I was trying to make sure that the typewriter works as before but as i was adding category one at a time for it link to the corresponding url it was rendering same text twice. so i had to remove loop props to make sure text render only once.

@Anmol-Baranwal
Copy link
Collaborator

So I was trying to make sure that the typewriter works as before but as i was adding category one at a time for it link to the corresponding url it was rendering same text twice. so i had to remove loop props to make sure text render only once.

Can you show a video or jam of that? It would be great.

@Ameya02
Copy link
Contributor Author

Ameya02 commented Oct 7, 2023

linkshub2

@CBID2 CBID2 changed the title Feat redirect to the corresponding section based on options in empty page screen feat: redirect to the corresponding section based on options in empty page screen Oct 7, 2023
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @Ameya02! :)

@CBID2 CBID2 merged commit 6683154 into rupali-codes:main Oct 7, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Might take time to finish hacktoberfest hacktoberfest2023 hacktoberfest-accepted Issues/PR that are acceptable in hacktoberfest priority: low Addition of new links/categories or doing any small task (e.g fixing typos)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] redirect to the corresponding section based on options in empty page screen
4 participants