-
-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: redirect to the corresponding section based on options in empty page screen #1875
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Ameya02, for creating this pull request and contributing to LinksHub! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Looks good to me.
@Ameya02 Well done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, the typewriter was clearing the subcategory letter-by-letter but now its clearing it all together, can we fix this?
So I was trying to make sure that the typewriter works as before but as i was adding category one at a time for it link to the corresponding url it was rendering same text twice. so i had to remove loop props to make sure text render only once. |
Can you show a video or jam of that? It would be great. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done @Ameya02! :)
Fixes Issue
Closes #1735
Changes proposed
Added Link to wrap over the Typewriter component to redirect to the particular section page when click on the text
Removed autostart and loop as it causes the text to repeat twice
Screenshots
Note to reviewers