Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: animate backToTop btn #171

Merged
merged 4 commits into from
Feb 16, 2023
Merged

Conversation

Lourvens
Copy link
Contributor

Closes #166

Animate backToTop buttons

  • make the BackToTop animated when appearing on the screen
  • add a transition library to make it possible

Screenshots

chrome-capture-2023-1-10 (2)

@vercel
Copy link

vercel bot commented Feb 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 16, 2023 at 5:05PM (UTC)

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please resolve this issue?

image

@Lourvens
Copy link
Contributor Author

now think the problem was resolved the first package doesn't support react.18 I replaced it by another

@rupali-codes
Copy link
Owner

Could you please resolve merge conflicts?

@Lourvens
Copy link
Contributor Author

I resolved the merge conflict

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have encountered some issues:

  1. backToTop buttons shows up when there's nothing to scroll

image

  1. footer should not overlap the button

image

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, could you add transition on hover too?

@Lourvens
Copy link
Contributor Author

Great, I am done now

Copy link
Owner

@rupali-codes rupali-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much

@rupali-codes rupali-codes merged commit 153c52e into rupali-codes:main Feb 16, 2023
@Lourvens
Copy link
Contributor Author

you are welcome

@Lourvens Lourvens deleted the feat-animateBtn branch February 16, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] animate the to-top button
2 participants