added footer

[Aadarsh805]

Fixes Issue

Closes #117

Screenshots

Note to reviewers

Suggest changes if any

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
linkshub	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 11, 2023 at 9:23AM (UTC)

[rupali-codes]

Also, can we make background blur instead of using this solid color?

[Aadarsh805]

Also, can we make background blur instead of using this solid color?

something like this?

[rupali-codes]

Hmm.

Also, can we make background blur instead of using this solid color?

something like this?

Looks good tho, but wud hv been better if cud just make it within right container. If not, just commit the changes

[Aadarsh805]

maybe what we can do is instead of keeping it fixed, I add the footer static inside the right container and make cards container have a fixed height just above to the footer
something like that
let me try

[rupali-codes]

maybe what we can do is instead of keeping it fixed, I add the footer static inside the right container and make cards container have a fixed height just above to the footer something like that let me try

Okay

[Aadarsh805]

closes #161 as well

[Aadarsh805]

here's how it looks on mine

screen-capture.17.webm

[rupali-codes]

Great work Aadarsh. But having 2 small issues:

1. It's showing 2 scrollbars

2. Ig it should not be fixed this way, what i meant is when user reaches the end of the page, then we should display this footer. And for initial state (when no category is selected) it should be at the bottom of the page just like it's now.

[rupali-codes]

closes #161 as well

And thanks for this 😊

[Aadarsh805]

Great work Aadarsh. But having 2 small issues:

1. It's showing 2 scrollbars

2. Ig it should not be fixed this way, what i meant is when user reaches the end of the page, then we should display this footer. And for initial state (when no category is selected) it should be at the bottom of the page just like it's now.

I actually fixed the bigger scrollbar, that's exactly what is being addressed in this issue #161, I'll look on it again must be because of smaller screen size ig
and I'll try to implement it the other way as you suggested
One question, do we want the top bar fixed? i suggest it should be

[rupali-codes]

@Aadarsh805 I guess not for desktop but we can fix it t top for other devices(phone, tabs). Cz' we have sidebar in desktop so there's no need for it necessarily

[Aadarsh805]

Updated

screen-capture.19.webm

[rupali-codes]

Thank you so much Aadarsh, appreciate it. Now it looks perfect.