Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add official docs of Ember.js⚡ #1528

Merged
merged 2 commits into from
Aug 10, 2023
Merged

feat: add official docs of Ember.js⚡ #1528

merged 2 commits into from
Aug 10, 2023

Conversation

Nishitbaria
Copy link
Contributor

@Nishitbaria Nishitbaria commented Aug 9, 2023 •
edited by CBID2
Loading

Fixes Issue

Closes #1452

Changes proposed

Add JSON data about Ember.js

Screenshots

image

Note to reviewers

kindly Review it And merge it happy hacking :)

@vercel
Copy link

vercel bot commented Aug 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 10, 2023 1:44am

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Aug 9, 2023
@github-actions github-actions bot added the goal: new-feature New feature or request label Aug 9, 2023
github-actions[bot]
github-actions bot reviewed Aug 9, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Nishitbaria, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@CBID2 CBID2 added goal: new-link Addition of new links related contributions quick-fix Shouldn't take much time to finish gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) and removed documentation Improvements or additions to documentation goal: new-feature New feature or request labels Aug 9, 2023
CBID2
CBID2 approved these changes Aug 10, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CBID2 CBID2 added the status: ready-to-merge Approved & its ready-to-merge label Aug 10, 2023
@k-deepak04 k-deepak04 merged commit 7c2e047 into rupali-codes:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@CBID2 CBID2 CBID2 approved these changes

@k-deepak04 k-deepak04 k-deepak04 approved these changes

Assignees

@Nishitbaria Nishitbaria

Labels
goal: new-link Addition of new links related contributions gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) quick-fix Shouldn't take much time to finish status: ready-to-merge Approved & its ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Add] Add Official Docs for Ember.js
3 participants
@Nishitbaria @k-deepak04 @CBID2