Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: summarize colors #1377

Merged
merged 4 commits into from
Jul 25, 2023
Merged

chore: summarize colors #1377

merged 4 commits into from
Jul 25, 2023

Conversation

rupali-codes
Copy link
Owner

Hi, I have stored all the color values in tailwind.config.js file

Fixes Issue

closes #1372

Changes proposed

  • added colors to tailwind.config.js file
  • replaced all color values with newly added variables

Screenshots

image

Note to reviewers

Please review carefully and let me know if i missed any spot

@vercel
Copy link

vercel bot commented Jul 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 9:22am

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, rupali-codes, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@CBID2
Copy link
Collaborator

CBID2 commented Jul 23, 2023

Hi @rupali-codes! :) Can you add me as a co-author since I found the hex codes for the new colors?

@rupali-codes
Copy link
Owner Author

Hi @rupali-codes! :) Can you add me as a co-author since I found the hex codes for the new colors?

Do you mean i should assign this issue to both of us?

@rupali-codes
Copy link
Owner Author

Though i tried to improve the accessibility, you may check once :)

@CBID2
Copy link
Collaborator

CBID2 commented Jul 23, 2023

@rupali-codes
Copy link
Owner Author

Hi @rupali-codes! :) Can you add me as a co-author since I found the hex codes for the new colors?

I see, but these colors are not those chosen by you i guess,

@CBID2
Copy link
Collaborator

CBID2 commented Jul 24, 2023

Hi @rupali-codes! :) Can you add me as a co-author since I found the hex codes for the new colors?

I see, but these colors are not those chosen by you i guess,

Ohhh. I think you should use them @rupali-codes. They make the background more accessible.

@rupali-codes
Copy link
Owner Author

Hi @rupali-codes! :) Can you add me as a co-author since I found the hex codes for the new colors?

I see, but these colors are not those chosen by you i guess,

Ohhh. I think you should use them @rupali-codes. They make the background more accessible.

Wait, i'm merging this PR becuase this issue was specifically for putting the colors in tailwing.config.js file, can u create a sperate PR for that?

@rupali-codes rupali-codes merged commit 4d6ba7d into main Jul 25, 2023
@rupali-codes rupali-codes deleted the set-colors branch July 25, 2023 09:23
@rupali-codes rupali-codes added quick-fix Shouldn't take much time to finish accessibility Code is not up to WCAG standards labels Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Code is not up to WCAG standards quick-fix Shouldn't take much time to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Making Background Colors Accessible Part 2
2 participants