Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added css filters to frontend/ui-generators #1183

Merged
merged 4 commits into from
Jul 1, 2023
Merged

Added css filters to frontend/ui-generators #1183

merged 4 commits into from
Jul 1, 2023

Conversation

hereisSwapnil
Copy link
Contributor

@hereisSwapnil hereisSwapnil commented Jun 27, 2023 •
edited
Loading

Fixes Issue

Closes : #1110

Changes proposed

I have added CSS Filters to Frontend/UI Generators

Screenshots

image

Note to reviewers

Review and Merge this PR under GSSOC'23

@vercel
Copy link

vercel bot commented Jun 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
linkshub ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 30, 2023 8:58am

github-actions[bot]
github-actions bot reviewed Jun 27, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Swapnil-Singh-99, for creating this pull request and contributing to LinksHub! 💗

The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀

@rupali-codes
Copy link
Owner

rupali-codes commented Jun 29, 2023 •
edited
Loading

@swapnil-singh-99 please add closes #1110 in the description of this PR and also resolve the merge conflicts :)

Please let us know if you need any kinda help

@rupali-codes rupali-codes added gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos) goal: new-link Addition of new links related contributions labels Jun 29, 2023
@rupali-codes rupali-codes requested a review from CBID2 June 29, 2023 12:41
@hereisSwapnil
Copy link
Contributor Author

@rupali-codes I have resolved conflicts

CBID2
CBID2 requested changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @swapnil-singh-99. I just found some proofreading errors in your description. Other than that, you are off to a great start! :)

database/frontend/ui-generators.json Outdated Show resolved Hide resolved
@hereisSwapnil hereisSwapnil requested a review from CBID2 June 29, 2023 13:22
CBID2
CBID2 previously approved these changes Jun 29, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2 CBID2 requested review from rupali-codes and k-deepak04 June 29, 2023 13:23
@k-deepak04
Copy link
Contributor

@swapnil-singh-99 please resolve the conflicts

k-deepak04
k-deepak04 suggested changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@k-deepak04 k-deepak04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

manage your changes with respect to the cureent updates,
try rebasing your code with the main branch and then add commits to prevent conflicts, rest all good.

@hereisSwapnil
Copy link
Contributor Author

manage your changes with respect to the cureent updates, try rebasing your code with the main branch and then add commits to prevent conflicts, rest all good.

@k-deepak04 Done Please review

@hereisSwapnil hereisSwapnil requested a review from k-deepak04 June 30, 2023 09:05
@k-deepak04
Copy link
Contributor

@CBID2 please review and merge it

CBID2
CBID2 approved these changes Jul 1, 2023
View reviewed changes
Copy link
Collaborator

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CBID2
Copy link
Collaborator

CBID2 commented Jul 1, 2023

@CBID2 please review and merge it

I can't merge it for some reason

@k-deepak04
Copy link
Contributor

@CBID2 please review and merge it

I can't merge it for some reason

i guess until rupali reviews this we cannot merge it

so @rupali-codes please review this

@rupali-codes rupali-codes merged commit b20b118 into rupali-codes:main Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@CBID2 CBID2 CBID2 approved these changes

@k-deepak04 k-deepak04 k-deepak04 approved these changes

@rupali-codes rupali-codes rupali-codes approved these changes

Assignees

@hereisSwapnil hereisSwapnil

Labels
goal: new-link Addition of new links related contributions gssoc GirlScript Summer of Code participants level1 Addition of new links/categories or doing any small task (e.g fixing typos)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Add] new links under UI Generator
4 participants
@hereisSwapnil @rupali-codes @k-deepak04 @CBID2