Skip to content

Conversation

Stevengre
Copy link

@Stevengre Stevengre commented Oct 10, 2025

The goal here is to allow us sync up the proof information with minimal but sufficient information for quick investigation.
The updated run-proof.sh will:

  1. export the proof's related commits of solana-token and mir-semantics
  2. export the proof's duration (maybe we should also export information like k version and machine info for reproducing the result.)
  3. export the least proof structure for investigation: kmir show --statistics --leaves.

@Stevengre Stevengre self-assigned this Oct 10, 2025
@Stevengre Stevengre marked this pull request as ready for review October 10, 2025 04:24
@Stevengre Stevengre marked this pull request as draft October 10, 2025 04:27
@Stevengre Stevengre marked this pull request as ready for review October 10, 2025 04:40
Copy link
Member

@jberthold jberthold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. We could refine it a bit more, or merge and iterate.

Comment on lines 72 to +117
uv --project mir-semantics/kmir run -- \
kmir show --proof-dir artefacts/proof p-token.smir.$start \
--full-printer > artefacts/proof/${name}-full.txt
uv --project mir-semantics/kmir run -- \
kmir show --dir artefacts/proof p-token.smir.$start \
--statistics --leaves >> "${status_file}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might not need an extra proof_status directory... How about we put the commit hash of solana-token at the end of the proof directory?
This will prevent overwriting earlier results, and we can just go by file date of the proof directory.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be another feature different from this one. The goal for this PR in my mind is to replace the previous proof_status.md file which only provides the structure of the proof that is not easy to investigate the error and update #24 . Additionally, we can have a proof status shared with all the team without rerunning on our own machine.

On the other hand, I think this feature is a version control of proofs which I want to introduce in another PR.

I'd like to merge this pr first and provide an issue to track this required feature. What do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 57 to 58
REPO_COMMIT=$(git rev-parse --short HEAD 2>/dev/null || echo "unknown")
MIR_COMMIT=$(git -C mir-semantics rev-parse --short HEAD 2>/dev/null || echo "unknown")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could mark the commits with -dirty if there are uncommitted changes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants