This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Regression new updated expected output #1044
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehildenb
commented
Mar 28, 2024
Comment on lines
-1
to
+8
| [Error] Compiler: Only claims and simplification rules are allowed in proof modules. | ||
| [Error] Compiler: Only claims and simplification rules are allowed in proof | ||
| modules. | ||
| Source(rule-spec.k) | ||
| Location(6,10,6,43) | ||
| 6 | rule <k> doIt(foo) => doIt(0) ... </k> | ||
| . ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| [Error] Compiler: Had 1 structural errors. | ||
| Traceback (most recent call last): |
There was a problem hiding this comment.
I guess for these errors we can:
- Add option
--no-wrap-exctopyk prove ..., and pass it through tokprove --dry-run ... - Implement custom error handling for
pyk prove ...similar to what we do forkompile
The only challenge is that here we are using a temporary file as the JSON dump, and that will show up in the error message. So I guess we also need to:
- Allow specifying
--tmp-dir ...forpyk prove ..., and use that directory for dumping the temporary files. - Use a more deterministic filename for the temporary JSON file we dump.
OR
- Dump the JSON in a file immediately next to the spec file as a convention.
OR
- Strip that line of output in the testing harness.
ehildenb
commented
Mar 28, 2024
Comment on lines
-1
to
+27
| kore-exec: [] Warning (WarnStuckClaimState): | ||
| The configuration's term unifies with the destination's term, but the implication check between the conditions has failed. Location: a2-spec.k:7:1-8:18 | ||
| Context: | ||
| (InfoReachability) while checking the implication | ||
| #Ceil ( bar ( X ) ) | ||
| #And | ||
| #Not ( #Ceil ( baz ( X ) ) | ||
| #And | ||
| { | ||
| bar ( X ) | ||
| #Equals | ||
| baz ( X ) | ||
| } ) | ||
| #And | ||
| <k> | ||
| end ( bar ( X ) ) ~> .K | ||
| </k> | ||
| #And | ||
| { | ||
| true | ||
| #Equals | ||
| X <Int 0 | ||
| } | ||
| [Error] Prover: backend terminated because the configuration cannot be rewritten further. See output for more details. | ||
| APRProof: A2-SPEC.s2 | ||
| status: ProofStatus.FAILED | ||
| admitted: False | ||
| nodes: 5 | ||
| pending: 0 | ||
| failing: 1 | ||
| vacuous: 0 | ||
| stuck: 1 | ||
| terminal: 0 | ||
| refuted: 0 | ||
| bounded: 0 | ||
| execution time: 0s | ||
| Subproofs: 0 | ||
| 1 Failure nodes. (0 pending and 1 failing) | ||
|
|
||
| Failing nodes: | ||
|
|
||
| Node id: 5 | ||
| Failure reason: | ||
| Matching failed. | ||
| The following cells failed matching individually (antecedent #Implies consequent): | ||
| K_CELL: end ( bar ( X:Int ) ) #Implies end ( baz ( X:Int ) ) | ||
| Path condition: | ||
| #Ceil ( bar ( X:Int ) ) | ||
| Failed to generate a model. | ||
|
|
||
| Join the Runtime Verification Discord server for support: https://discord.gg/CurfmXNtbN |
There was a problem hiding this comment.
This failure information message contains largely the same information as the original message, basically the part that failed and path condition to it. Are we happy with this new way of presenting information?
ehildenb
commented
Mar 28, 2024
Comment on lines
-1
to
+10
| <k> | ||
| "open" ~> "(\"foo\", \"r\")\n" ~> "" ~> .K | ||
| </k> | ||
| <generatedTop> | ||
| <k> | ||
| "open" | ||
| ~> "(\"foo\", \"r\")\n" | ||
| ~> "" | ||
| </k> | ||
| <generatedCounter> | ||
| 0 | ||
| </generatedCounter> | ||
| </generatedTop> |
There was a problem hiding this comment.
pyk prints out KSequence on newlines, as an aesthetic choice. Do we want to allow this and make it default, or retain the original version? I guess printing KSequence on newlines would look bad if there is a KSequence inside of some other construct in the configuration.
ehildenb
commented
Mar 28, 2024
Comment on lines
-1
to
+8
| <k> | ||
| x = ( 0 ~> .K ) ; .RecordDescr ~> .K | ||
| </k> | ||
| <generatedTop> | ||
| <k> | ||
| ... key: x = value: 0 ~> .K ; .RecordDescr ~> .K | ||
| </k> | ||
| <generatedCounter> | ||
| 0 | ||
| </generatedCounter> | ||
| </generatedTop> |
There was a problem hiding this comment.
This seems to be a bug in how pyk unparser works.
ehildenb
commented
Mar 28, 2024
Comment on lines
-1
to
+9
| <k> | ||
| bar ( 0 , 0 ) ~> bar ( 0 , 0 ) ~> .K | ||
| </k> | ||
| <generatedTop> | ||
| <k> | ||
| bar ( 0 , 0 ) | ||
| ~> bar ( 0 , 0 ) | ||
| </k> | ||
| <generatedCounter> | ||
| 1 | ||
| </generatedCounter> | ||
| </generatedTop> |
There was a problem hiding this comment.
We should be including the tail of the sequence every time in pyks unparser.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening this issue to discuss the various changes that running
make update-resultscauses inregression-newtest-suite. I figure we can keep this open as we triage all these things.