Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build_rule #4744

Merged
merged 4 commits into from
Jan 23, 2025
Merged

Fix build_rule #4744

merged 4 commits into from
Jan 23, 2025

Conversation

Stevengre
Copy link
Contributor

During the verification of automatic generated kclaim from summarization, current build_rule may lead to Could not determine sort of term error because the introduction of new variables in build_rule.

This PR tries the best to keep the sort of variables during their corresponding var introduction and keep its default behavior.

@rv-jenkins rv-jenkins changed the base branch from master to develop January 22, 2025 15:13
@ehildenb
Copy link
Member

@Stevengre please add a test of this behavior where appropriate. There is a testing harness for build_rule here:

@pytest.mark.parametrize('lhs,rhs,keep_vars,expected', BUILD_RULE_TEST_DATA, ids=count())
, which you can add to. Make sure that your test is failing before your change, and passing after your change.

@Stevengre Stevengre requested a review from ehildenb January 23, 2025 08:13
@automergerpr-permission-manager automergerpr-permission-manager bot merged commit 6482ee2 into develop Jan 23, 2025
18 checks passed
@automergerpr-permission-manager automergerpr-permission-manager bot deleted the fix-build-rule branch January 23, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants