Update dependency: deps/haskell-backend_release #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberthold
reviewed
Jul 14, 2023
| @@ -53,6 +66,7 @@ jobs: | |||
| fi | |||
|
|
|||
| if ${changed}; then | |||
| cabal update | |||
There was a problem hiding this comment.
IDK why this is necessary... but without it, the cabal freeze call would not find any hackage-supplied packages (only the co-log that we request explicitly in the cabal.project would be available). 🤷♂️
jberthold
reviewed
Jul 14, 2023
Comment on lines
+46
to
+49
| - uses: haskell/actions/setup@v2 | ||
| id: setup-haskell | ||
| with: | ||
| ghc-version: ${{ env.ghc_version }} |
There was a problem hiding this comment.
The cabal freeze command was previously picking up the newer ghc from the runner installation (which brought a base library newer than our requested one). I tried running it under a nix shell but with the same result.
The Haskell installation takes some time and we need to manually change the GHC version when we upgrade but we would anyway want to do that IMHO
goodlyrottenapple
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.