Remove "log-timing" and "log-fallbacks" RPC log options
#4015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geo2a
changed the title
"log-timing" RPC log option"log-timing" and "log-fallbakcs" RPC log options
geo2a
changed the title
"log-timing" and "log-fallbakcs" RPC log options"log-timing" and "log-fallbacks" RPC log options
rv-jenkins
pushed a commit
to runtimeverification/k
that referenced
this pull request
Aug 6, 2024
This option is unused and all its use cases are subsumed by the `-l Timing --log-format json` non-RPC log option. For reference, here's the Haskell Backend PR that stops emitting the timing RPC log entries: runtimeverification/haskell-backend#4015
booster/tools/booster/Proxy.hs
Outdated
| , logFallbacks = execReq.logFallbacks | ||
| , logTiming = execReq.logTiming | ||
| , logFallbacks = Nothing | ||
| , logTiming = Nothing |
There was a problem hiding this comment.
Can we get rid of these fields or is there a reason to hold off?
goodlyrottenapple
approved these changes
Aug 6, 2024
PetarMax
pushed a commit
to runtimeverification/k
that referenced
this pull request
Aug 6, 2024
This option is unused and all its use cases are subsumed by the `-l Timing --log-format json` non-RPC log option. For reference, here's the Haskell Backend PR that stops emitting the timing RPC log entries: runtimeverification/haskell-backend#4015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This options are unused and all ther use cases are subsumed by the
-l Timingand-l Abortsnon-RPC log option.