Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify and compact kompilation for Haskell vs Booster #2144

Merged
merged 12 commits into from
Nov 29, 2023
Merged

Simplify and compact kompilation for Haskell vs Booster #2144

merged 12 commits into from
Nov 29, 2023

Conversation

ehildenb
Copy link
Member

@ehildenb ehildenb commented Oct 30, 2023 •
edited
Loading

Blocked on: #2164

This changes the kompilation process for the Haskell backend to always prepare the booster for compilation, and just decide whether to use it at runtime instead. This simplifies the logic of run_kompile a little bit.

  • run_kompile in kompile.py is simplified to apply the same logic for HASKELL and HASKELL_BOOSTER. In one case, the haskell_binary flag is now correctly passed to HASKELL_BOOSTER compilation option, which seemed to be missed before.
  • The tests are adjusted to simplify their logic given this compaction in kompilation logic.
  • Documentation is updated.

@ehildenb ehildenb mentioned this pull request Oct 30, 2023
Merged
@ehildenb ehildenb self-assigned this Oct 30, 2023
@ehildenb ehildenb marked this pull request as ready for review November 3, 2023 17:57
tothtamas28
tothtamas28 reviewed Nov 3, 2023
View reviewed changes
kevm-pyk/src/kevm_pyk/__main__.py Outdated Show resolved Hide resolved
kevm-pyk/src/kevm_pyk/__main__.py Outdated Show resolved Hide resolved
kevm-pyk/src/kevm_pyk/cli.py Outdated Show resolved Hide resolved
kevm-pyk/src/kevm_pyk/kompile.py Outdated Show resolved Hide resolved
tothtamas28
tothtamas28 reviewed Nov 6, 2023
View reviewed changes
kevm-pyk/src/kevm_pyk/kompile.py Outdated Show resolved Hide resolved
kevm-pyk/src/kevm_pyk/cli.py Outdated Show resolved Hide resolved
@ehildenb ehildenb mentioned this pull request Nov 8, 2023
Merged
@rv-jenkins rv-jenkins merged commit 42ce78b into master Nov 29, 2023
11 checks passed
@rv-jenkins rv-jenkins deleted the simplify-haskell-kompile branch November 29, 2023 16:27
@palinatolmach palinatolmach mentioned this pull request Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tothtamas28 tothtamas28 tothtamas28 approved these changes

@nwatson22 nwatson22 Awaiting requested review from nwatson22

Assignees

@ehildenb ehildenb

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ehildenb @tothtamas28 @rv-jenkins @anvacaru