feat: Create spot pod by adding bidPerGpu argument#186
Open
raghuveer-s wants to merge 1 commit intorunpod:mainfrom
Open
feat: Create spot pod by adding bidPerGpu argument#186raghuveer-s wants to merge 1 commit intorunpod:mainfrom
raghuveer-s wants to merge 1 commit intorunpod:mainfrom
Conversation
Author
|
Related issue: #11 |
Contributor
|
Thanks! Sorry for getting back after so long, Im currently in the process to own this repository and help get things moved in. Ill be looking deeper into this coming week or so, to see what I can do to get this merged in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create Spot Pod
The create command can only create on-demand pods at the moment since it uses
podFindAndDeployOnDemandin the GraphQL API underneath. If we want to create spot pods, we need to use thepodRentInterruptablemutation which needs thebidPerGpufield as part of its input.How I tested it
Manually tested and verified with the RunPod dashboard as well.
There are a few cases to watch for: