Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating branch #223

Merged
merged 43 commits into from
Nov 15, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
8c97085
improve deploy logic - separate dev and prod part 1
DireLines Nov 10, 2023
6ed7f06
reversed branches
DireLines Nov 10, 2023
2b2a7f5
helpers needed for redeploy
DireLines Nov 10, 2023
4146d1e
bug fixes for redeploy
DireLines Nov 10, 2023
47a7c1e
Merge pull request #219 from DireLines/main
justinmerrell Nov 12, 2023
d88a8f1
fix: linting
justinmerrell Nov 12, 2023
63494e0
Update functions.py
justinmerrell Nov 12, 2023
d417e53
Update functions.py
justinmerrell Nov 12, 2023
7b5e714
Update functions.py
justinmerrell Nov 12, 2023
b6fdb38
Update functions.py
justinmerrell Nov 12, 2023
27ede5d
Update test_project_functions.py
justinmerrell Nov 12, 2023
a6d2be5
fix: listing and tests
justinmerrell Nov 12, 2023
5ab5944
fix: tests and linting
justinmerrell Nov 12, 2023
6210655
Update functions.py
justinmerrell Nov 12, 2023
f0ed7b7
Update test_project_functions.py
justinmerrell Nov 12, 2023
1459127
Update test_project_functions.py
justinmerrell Nov 12, 2023
72450b8
Update test_project_functions.py
justinmerrell Nov 12, 2023
76c2f67
Update test_project_functions.py
justinmerrell Nov 13, 2023
0e1a029
Update test_project_functions.py
justinmerrell Nov 13, 2023
a1de81e
fix: add missing tests
justinmerrell Nov 13, 2023
04faade
fix: missing coverage
justinmerrell Nov 13, 2023
c99e408
Update test_project_functions.py
justinmerrell Nov 13, 2023
ee663e2
fix: tests
justinmerrell Nov 13, 2023
703e952
Update test_project_functions.py
justinmerrell Nov 13, 2023
1f062e2
Update test_project_functions.py
justinmerrell Nov 13, 2023
045fef5
Update test_project_functions.py
justinmerrell Nov 13, 2023
20b8136
Update functions.py
justinmerrell Nov 13, 2023
7a95891
Update test_project_functions.py
justinmerrell Nov 13, 2023
f923183
Update test_project_functions.py
justinmerrell Nov 13, 2023
195852c
fix: tests
justinmerrell Nov 13, 2023
a73c21e
fix: tests
justinmerrell Nov 13, 2023
fc2f7bd
Update test_project_functions.py
justinmerrell Nov 13, 2023
70bdf37
Update test_project_functions.py
justinmerrell Nov 13, 2023
69fe168
Merge pull request #220 from runpod/enhanced-deploy
justinmerrell Nov 13, 2023
f45825a
feat: create json logs
justinmerrell Nov 14, 2023
68c5695
fix: log format
justinmerrell Nov 14, 2023
52b0ace
fix: log formatting
justinmerrell Nov 14, 2023
fea875f
fix: format more logs
justinmerrell Nov 14, 2023
513c1c7
Update rp_job.py
justinmerrell Nov 14, 2023
b6039a5
Update rp_job.py
justinmerrell Nov 14, 2023
c22b4c8
Merge pull request #221 from runpod/json-logs
justinmerrell Nov 14, 2023
4b9170c
Update CHANGELOG.md
justinmerrell Nov 14, 2023
3d78e39
Merge pull request #222 from runpod/1.3.4-Update
justinmerrell Nov 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: tests and linting
  • Loading branch information
justinmerrell committed Nov 12, 2023
commit 5ab59446e7fb65b4919631d319950828af17020d
7 changes: 6 additions & 1 deletion runpod/cli/groups/project/functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import os
import sys
import time
import uuid
import datetime

Expand Down Expand Up @@ -165,6 +164,9 @@ def start_project(): # pylint: disable=too-many-locals, too-many-branches
if not project_pod_id:
project_pod_id = _launch_dev_pod()

if project_pod_id is None:
return None

with SSHConnection(project_pod_id) as ssh_conn:

project_path_uuid = f'{config["project"]["volume_mount_path"]}/{config["project"]["uuid"]}'
Expand Down Expand Up @@ -314,6 +316,9 @@ def create_project_endpoint():
if not project_pod_id:
project_pod_id = _launch_dev_pod()

if project_pod_id is None:
return None

with SSHConnection(project_pod_id) as ssh_conn:
project_path_uuid = f'{config["project"]["volume_mount_path"]}/{config["project"]["uuid"]}'
project_path_uuid_prod = os.path.join(project_path_uuid, 'prod')
Expand Down
1 change: 1 addition & 0 deletions tests/test_cli/test_cli_groups/test_project_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ def test_failed_pod_launch(self, mock_attempt_pod, mock_get_pod):

with patch('builtins.print') as mock_print, \
patch('runpod.cli.groups.project.functions.load_project_config'):

start_project()
mock_print.assert_called_with(
"Selected GPU types unavailable, try again later or use a different type.") # pylint: disable=line-too-long
Expand Down