Skip to content

Conversation

christian-bromann
Copy link
Contributor

We had some experiments rendering web components within the readme. As we don't further proceed this experiment we can remove the example directory for it.

@christian-bromann
Copy link
Contributor Author

Working on updating wdio-vscode-service to be able to use latest WebdriverIO deps as well.

@christian-bromann christian-bromann removed the request for review from sourishkrout December 8, 2022 05:39
@christian-bromann christian-bromann marked this pull request as draft December 8, 2022 05:39
@sourishkrout
Copy link
Contributor

Related to #74

@christian-bromann
Copy link
Contributor Author

@sourishkrout this is ready for review, it updates all dependencies as well (except for @vscode/webview-ui-toolkit due to microsoft/vscode-webview-ui-toolkit#432).

@christian-bromann christian-bromann changed the title Remove examples for web components Remove examples for web components / Update dependencies Dec 9, 2022
@sourishkrout sourishkrout self-requested a review December 9, 2022 01:25
Copy link
Contributor

@sourishkrout sourishkrout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌🏼

@christian-bromann christian-bromann force-pushed the cb-remove-web-component-example branch from fba9b58 to dcf3543 Compare December 9, 2022 16:55
@christian-bromann christian-bromann merged commit 12da406 into main Dec 9, 2022
@christian-bromann christian-bromann deleted the cb-remove-web-component-example branch December 9, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants