feat: upgrade mmdb-lib to v3 #920
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Values stored in the database as uint64 or uint128 will now be decoded to BigInt. Previously, they were decoded as strings. This change comes from mmdb-lib v3 which now uses BigInt for all 64-bit and 128-bit unsigned integers.
oschwald
commented
Aug 1, 2025
| "lib": ["ES2019"], | ||
| "target": "ES2019" | ||
| "lib": ["ES2020"], | ||
| "target": "ES2020" |
There was a problem hiding this comment.
This adds support for BigInt literals. We could also do BigInt(...) and stick with ES2019 if that is preferred.
runk
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Values stored in the database as uint64 or uint128
will now be decoded to BigInt. Previously, they were decoded as strings.
This change comes from mmdb-lib v3 which now uses BigInt for all 64-bit
and 128-bit unsigned integers.