Fix built-in property visibility bug cause by LwcFlavor #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinfagnani
changed the title
|
Great. This is passing with |
|
All tests passing now. @rictic |
rictic
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a rough one to figure out.
The way flavors work they all get a chance to work against a definition and potentially refine features. A bug in LwcFlavor caused it to do work again non-LWC definitions and part of its feature refinement is to default all class members to protected visibility. This refinement was running against all built-in definitions cause built-in public properties to be changed to protected. This was only caught by one security test in lit-analyzer because lit-analyzer filters out non-public fields before type-checking.