Skip to content

Conversation

Koitere
Copy link
Contributor

@Koitere Koitere commented Oct 4, 2025

  • Added functionality for displaying maximum hits of monsters in the side panel
  • Added functionality for displaying attack style of monsters in the side panel
  • Added ability to enable/disable the side panel in the configuration.
  • Updated some tags for the plugin
  • Fixed a few errors in the database

@runelite-github-app
Copy link

runelite-github-app bot commented Oct 4, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented Oct 4, 2025

Internal use only: Reviewer details Maintainer details

riktenx
riktenx previously approved these changes Oct 6, 2025
@tylerwgrass
Copy link
Member

@tylerwgrass tylerwgrass added the waiting for author waiting for the pr author to make changes or respond to questions label Oct 7, 2025
@Koitere
Copy link
Contributor Author

Koitere commented Oct 7, 2025

You should also filter on your config group in onConfigChanged: https://github.com/Koitere/monster-stats/compare/e2ac9fb91a959472ddd1722e6c41e13be1e49e2c..Koitere:e2867e454dc4af12efcd436bd532615248ab7374#diff-edb2c1babdb70209de3eba7c5f0d19302ee4b35b9a7b5ff4ad4e1989d4809cd1R101

Good call, I've made this change on my main branch now. Do I need to make a new pull request or how can I update this one with the new hash?

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Oct 7, 2025
@tylerwgrass
Copy link
Member

push a change to your plugin hub branch (https://github.com/Koitere/plugin-hub/tree/monsterstats) with the updated commit

@Koitere
Copy link
Contributor Author

Koitere commented Oct 7, 2025

Occurred to me immediately after I commented that.. thanks! Done now.

@riktenx riktenx merged commit 36bee84 into runelite:master Oct 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants