Update phoenix-necklace-jingle #9197
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed creating sound from code, instead shipping empty wav in JAR now. From current version in pluginhub: Added option to play any ingame sound in game by sound ID, alternatively play any wav file instead that can be placed in the .Runelite folder by the user.
|
|
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
|
Accidentally closed and reopened a new PR instead of editing the old one, apologies. Here's the old PR for reference: #9104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed creating sound from code, instead shipping empty wav in JAR now.
From current version in pluginhub: Added option to play any ingame sound in game by sound ID, alternatively play any wav file instead that can be placed in the .Runelite folder by the user.