Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade naturalspeech #7383

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Upgrade naturalspeech #7383

wants to merge 4 commits into from

Conversation

phyce
Copy link
Contributor

@phyce phyce commented Feb 9, 2025

Major upgrade to Natural Speech plugin

  • Removed warning as all voice models are now hosted on github.

Probably best to look at this as a new plugin as the codebase has been almost entirely rewritten. If there's anything I can do to make the process easier for you please let me know

@TheLouisHong has started a document with some information that will hopefully help with the review of this PR, found here:
https://github.com/phyce/rl-natural-speech/blob/master/src/main/java/dev/phyce/naturalspeech/README.md

Major upgrade to Natural Speech plugin
@runelite-github-app
Copy link

runelite-github-app bot commented Feb 9, 2025

Includes non-plugin changes

naturalspeech: d31da91b698b031d5de748f56feb7d1b190e45d9...a68d327635ff5f014bfb538401d91fca11d9e2ef

@phyce phyce requested a review from a team as a code owner February 9, 2025 16:34
@abextm
Copy link
Member

abextm commented Feb 9, 2025

You can't use different versions of dependencies we already ship, it will break on the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants