Examine items #148
Merged
Examine items #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clementop
commented
May 31, 2020
| public constructor() { | ||
| logger.info('Parsing examine data...'); | ||
| this.items = parseData('data/config/examine-item-data.yaml'); | ||
| this.npcs = new Map<number, Examine>(); |
Contributor
Author
There was a problem hiding this comment.
there are some examines for "monsters" in osrsbox-db, however the ID numbers do not correspond with 435 cache id numbers. For this reason, I've excluded these from this initial PR. Not sure how we want to approach these.
clementop
commented
May 31, 2020
| logger.info('Parsing examine data...'); | ||
| this.items = parseData('data/config/examine-item-data.yaml'); | ||
| this.npcs = new Map<number, Examine>(); | ||
| this.objects = new Map<number, Examine>(); |
Contributor
Author
There was a problem hiding this comment.
I don't know of any source of examine messages for scenery objects.
TheBlackParade
suggested changes
May 31, 2020
Contributor
TheBlackParade
left a comment
TheBlackParade
left a comment
There was a problem hiding this comment.
Please also add the packet sizes inside incoming-packet-sizes.ts
Contributor
Author
Done. |
TheBlackParade
approved these changes
May 31, 2020
Contributor
TheBlackParade
left a comment
TheBlackParade
left a comment
There was a problem hiding this comment.
Beautiful, thank you~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only includes messages for items which exists in the 435 cache and also share the same name.