Skip to content

Conversation

@Hc747
Copy link
Contributor

@Hc747 Hc747 commented Apr 7, 2020

  • TODO: reasonable default byte buffer allocation size.
  • TODO: further reduce packet payload size.
    Reduces container update payload size by a factor of 16.

@Hc747
Copy link
Contributor Author

Hc747 commented Apr 7, 2020

@Promises @TheBlackParade
Requires a client sided modification.
Can be further optimised.

@Promises
Copy link
Collaborator

Promises commented Apr 7, 2020

@Hc747 do you need me to do the client side modifications?

@Hc747
Copy link
Contributor Author

Hc747 commented Apr 7, 2020

I’m happy to; can you link the client repo & appropriate place to handle the modification?

@Promises
Copy link
Collaborator

Promises commented Apr 7, 2020

@TheBlackParade
Copy link
Contributor

The outgoing packet buffer size can be reduced by pulling the packet sizes from the client and using those when creating new packets - search the array for the packet ID and use that size to create the buffer. That was the plan, anyways.

@Hc747
Copy link
Contributor Author

Hc747 commented Apr 8, 2020

@Promises @TheBlackParade Ready for merging.

@TheBlackParade TheBlackParade merged commit 89c8d49 into runejs:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants