ci(gha): set up CI #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Isac Byeonghoon Yoo <isac@runbear.io>
Signed-off-by: Isac Byeonghoon Yoo <isac@runbear.io>
Signed-off-by: Isac Byeonghoon Yoo <isac@runbear.io>
Signed-off-by: Isac Byeonghoon Yoo <isac@runbear.io>
Signed-off-by: Isac Byeonghoon Yoo <isac@runbear.io>
Signed-off-by: Isac Byeonghoon Yoo <isac@runbear.io>
Signed-off-by: Isac Byeonghoon Yoo <isac@runbear.io>
Signed-off-by: Isac Byeonghoon Yoo <isac@runbear.io>
Signed-off-by: Isac Byeonghoon Yoo <isac@runbear.io>
This reverts commit a12f5ac.
Signed-off-by: Isac Byeonghoon Yoo <isac@runbear.io>
This reverts commit 55eb498.
This reverts commit 8142c80.
Signed-off-by: Isac Byeonghoon Yoo <isac@runbear.io>
Signed-off-by: Isac Byeonghoon Yoo <isac@runbear.io>
thefron
approved these changes
Dec 20, 2023
Member
thefron
left a comment
thefron
left a comment
There was a problem hiding this comment.
LGTM! Also agree on dropping support up to Python 3.8.
| run: | | ||
| pip install -U build | ||
| python -m build . | ||
| - name: Publish package distributions to PyPI |
Member
There was a problem hiding this comment.
How are we bumping the package version while publishing? Can the version be automatically reflected to sdk version header?
Member
Author
There was a problem hiding this comment.
How are we bumping the package version while publishing?
Just update variable __version__ of plugbear/__init__.py. Flit will pick the variable and publish with it.
Can the version be automatically reflected to sdk version header?
Yeap. Because the __version__ is an ordinary python variable, and we use it on header directly.
Signed-off-by: Isac Byeonghoon Yoo <isac@runbear.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@thefron I think we should drop Python 3.8. The recent versions of pydantic.BaseModel and Pydantic's dataclass are both not fully compatible with Python 3.8 (related issue). Probably I can handle it using some tweaks, but I do not think it is worth it.