Update values.yaml metrics #323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metrics were indented one too many spaces. Fixed indentation so it is not under repos:. It should be same level as repos and not under
jamengual
approved these changes
Oct 17, 2023
|
@Austin37AF can you bump the chart version please?, and Thanks for the contribution |
|
This issue is stale because it has been open for 1 month with no activity. Remove stale label or comment or this will be closed in 1 month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics were indented one too many spaces. Fixed indentation so it is not under repos:. It should be same level as repos and not under
what
Changed indentation on metrics section under repos. Indentation was too many spaces causing metrics to be under repos instead of at the same level in the server side config.
why
This caused it to not send metrics properly as it was not formatted correctly in the yaml config.
tests
I have tested my changes by running a local environment and passing metrics along to Grafana to make sure they are properly working. Performed Atlantis tests to make sure all metrics were being sent via statsd.
references