chore: allow dashes and dots in the metric label values #5451
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IuryAlves
requested review from
GenPage,
nitrocode and
X-Guardian
and removed request for
a team
dosubot
bot
added
feature
The commit runatlantis@893ba90 introduced to the tally.ScopeOptions. This change causes dashes and dots in repository names, the base_repo label, to be converted to underscores. The Prometheus Data model allows any unicode characters in label values, as documented [here](https://prometheus.io/docs/concepts/data_model/\#:\~:text\=Label%20values%20may%20contain%20any%20Unicode%20characters.) Signed-off-by: IuryAlves <iuryalves20@gmail.com>
…drive/utils.go (main) (runatlantis#5449) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: IuryAlves <iuryalves20@gmail.com>
IuryAlves
force-pushed
the
iury/accept-dashes-and-dots-in-metric-label-values
branch
from
652f8fc to
1f6d1a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Allow dashes and dots in the metric label values.
why
A change was introduced in the commit 893ba90 to sanitize metric label names and values. This change caused dashes and dots in repository names(i.e. the base_repo label) to be converted to underscores.
This change does not comply to the Prometheus Data model specification, as it allows any unicode characters in label values, as documented here.
I also created a pull request to fix it in Tally: uber-go/tally#267, but I am hoping we can merge this PR while we wait for an approval from the tally maintainers.
tests
I couldn't figure out how to test those changes. I would appreciate some support with that.
references