Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support basepath for bitbucket server #509

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Support basepath for bitbucket server #509

merged 1 commit into from
Mar 1, 2019

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Mar 1, 2019

Previously we were stripping the basepath from the passed in URL. i.e.
if I passed in --bitbucket-base-url=https://me.com/basepath then we
would just strip off /basepath.

This change fixes that bug (#508).

Previously we were stripping the basepath from the passed in URL. i.e.
if I passed in --bitbucket-base-url=https://me.com/basepath then we
would just strip off /basepath.

This change fixes that bug (#508).
@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #509 into master will decrease coverage by 1.97%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #509      +/-   ##
==========================================
- Coverage   71.48%   69.51%   -1.98%     
==========================================
  Files          62       62              
  Lines        4465     4464       -1     
==========================================
- Hits         3192     3103      -89     
- Misses       1033     1130      +97     
+ Partials      240      231       -9
Impacted Files Coverage Δ
server/events/vcs/bitbucketserver/client.go 35.29% <100%> (+1.96%) ⬆️
server/events/runtime/apply_step_runner.go 38.18% <0%> (-48.19%) ⬇️
server/events/terraform/terraform_client.go 47.15% <0%> (-31.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8633b96...0a8e3e8. Read the comment docs.

@lkysow lkysow merged commit e9bee6e into master Mar 1, 2019
@lkysow lkysow deleted the bb-server-basepath branch March 1, 2019 14:17
@lkysow
Copy link
Member Author

lkysow commented Mar 1, 2019

Closes #508

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant