fix: send pipelineID in gitlabs SetCommitStatus if the mr gets found, fallback to branch ref #4785
+20
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
The SetCommitStatus call in the GitLab clients UpdateStatus function will now send the pipelineID when the MR is found.
why
This should prevent Atlantis from making duplicate pipelines in GitLab
tests
These changes have been running on our private Atlantis for around a month
references
This should fix
#3373 and #3722
additional notes
I've also opened #4784 separately as it's not quite the same issue. Let me know if it would be better to combine these