Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use shorter commit sha in version output #3163

Merged
merged 1 commit into from
Feb 25, 2023
Merged

fix: use shorter commit sha in version output #3163

merged 1 commit into from
Feb 25, 2023

Conversation

nitrocode
Copy link
Member

what

  • use shorter commit sha in version output

why

  • The full commit sha is too long. The first 7 chars is unique enough.

tests

  • I have tested my changes by testing locally
✗ go build -v -ldflags "-X 'main.commit=53e9e5880b0c662192d414cc0b455d8188051b99'" -o atlantis . && ./atlantis version
atlantis dev (commit: 53e9e58) (build date: unknown)

✗ go build -v -o atlantis . && ./atlantis version
atlantis dev (commit: none) (build date: unknown)

references

@nitrocode nitrocode added this to the v0.23.0 milestone Feb 25, 2023
@nitrocode nitrocode requested a review from a team as a code owner February 25, 2023 14:16
@github-actions github-actions bot added the go Pull requests that update Go code label Feb 25, 2023
@nitrocode nitrocode enabled auto-merge (squash) February 25, 2023 15:40
@nitrocode nitrocode merged commit 8774128 into main Feb 25, 2023
@nitrocode nitrocode deleted the include-commit-in-version-2 branch February 25, 2023 18:40
@albertorm95 albertorm95 mentioned this pull request May 19, 2023
Merged
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@nitrocode @ijames-gc
fix: use shorter commit sha in version output (runatlantis#3163)
a88cc01
ijames-gc pushed a commit to gocardless/atlantis that referenced this pull request Feb 13, 2024
@nitrocode @ijames-gc
fix: use shorter commit sha in version output (runatlantis#3163)
439796f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go code
Projects
None yet
Milestone
v0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocode @jamengual