fix: set ctx.PullRequestStatus in import_command_runner for import_requirements

[krrrr38]

what

• refactor: pull_status_fetcher contains vcsStatusName in struct / redu…
• import_command_runner need to set ctx.PullRequestStatus for import_re…

why

import_requirements not works fine, cause ctx.PullRequestStatus needs to be set by command runner like apply_command_runner

tests

• add import_command_runner unit test
• check forked repository that contains ctx.PullRequestStatus with following diff (cause, author cannot approve...)
  • import-requirements krrrr38/atlantis-debug#7 (comment)

diff --git a/server/events/command_requirement_handler.go b/server/events/command_requirement_handler.go
index 5b487c51..d86c4409 100644
--- a/server/events/command_requirement_handler.go
+++ b/server/events/command_requirement_handler.go
@@ -1,6 +1,8 @@
 package events

 import (
+       "fmt"
+
        "github.com/runatlantis/atlantis/server/core/config/raw"
        "github.com/runatlantis/atlantis/server/core/config/valid"
        "github.com/runatlantis/atlantis/server/events/command"
@@ -48,7 +50,7 @@ func (a *DefaultCommandRequirementHandler) ValidateImportProject(repoDir string,
                switch req {
                case raw.ApprovedRequirement:
                        if !ctx.PullReqStatus.ApprovalStatus.IsApproved {
-                               return "Pull request must be approved by at least one person other than the author before running import.", nil
+                               return fmt.Sprintf("Pull request must be approved by at least one person other than the author before running import. ctx.PullReqStatus=%+v", ctx.PullReqStatus), nil

references

• close import_requirements doesn't check current PullRequestStatus #2933

[krrrr38]

same logic with apply_command_runner

atlantis/server/events/apply_command_runner.go

Lines 103 to 115 in b1b0b89

	// Get the mergeable status before we set any build statuses of our own.
	// We do this here because when we set a "Pending" status, if users have
	// required the Atlantis status checks to pass, then we've now changed
	// the mergeability status of the pull request.
	// This sets the approved, mergeable, and sqlocked status in the context.
	ctx.PullRequestStatus, err = a.pullReqStatusFetcher.FetchPullStatus(baseRepo, pull, a.VCSStatusName)
	if err != nil {
	// On error we continue the request with mergeable assumed false.
	// We want to continue because not all apply's will need this status,
	// only if they rely on the mergeability requirement.
	// All PullRequestStatus fields are set to false by default when error.
	ctx.Log.Warn("unable to get pull request status: %s. Continuing with mergeable and approved assumed false", err)
	}

[krrrr38]

reduce following parameters

• repo models.Repo
  • pull models.PullRequest is enough.
• vcsstatusname string
  • this is a server configuration, so it should have be in the pullReqStatusFetcher struct.

[krrrr38]

added this test case

[krrrr38]

It might be better to remove ctx.PullRequestStatus and fetch it on command_requirement_handler.go 🤔 This is because ctx.PullRequestStatus should not be set as mutable value.

I tried to move a.PullReqStatusFetcher.FetchPullStatus(ctx.Pull) into command_requirement_handler. But if there are multiple projects, it calls multiple times even if PR is just one. So keep asis impl.

[GenPage]

LGTM

[nitrocode]

Thanks @krrrr38 for the fix.

I'm unsure how this PR was not merged into the last version. My mistake.