feat: allow lenient yaml unmarshal #2899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrocode
added
the
needs discussion
nitrocode
force-pushed
the
allow-lenient-yaml-unmarshal
branch
from
f454432
to
6e53540
Compare
nitrocode
force-pushed
the
allow-lenient-yaml-unmarshal
branch
from
6e53540
to
9b14113
Compare
|
Have we fully considered the implications of switching from strict unmarshalling? Are there any edge cases we haven't considered in regards to how we validate the config? From what I understand reading the yaml lib docs, it will just silently ignore any key added to the YAML file that does not have a corresponding field in the config struct |
|
Yes exactly. From the maintainers meeting, this would only be allowed to merge if this was gated behind a flag. It's not super critical to me. If someone would like to pick this back up and put it behind a flag, please feel free. I will close this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
projectskeytests
make testreferences