Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to atlantis-base:2022.11.13 and use cimg/go:1.19 #2673

Merged
merged 10 commits into from
Nov 13, 2022
Merged

Bump to atlantis-base:2022.11.13 and use cimg/go:1.19 #2673

merged 10 commits into from
Nov 13, 2022

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Nov 13, 2022 •
edited
Loading

what

  • Bump to atlantis-base:2022.11.13
  • Use cimg/go:1.19 image and corrected terraform path

why

  • Latest atlantis-base
  • The circleci/golang image does not have a 1.19 tag

references

notes

Note that /go/bin is in circlci/golang (debian 11.1 bullseye) missing from the cimg/go (debian 12-pre-release bookworm/sid) image.

✗ docker run -it circleci/golang:1.17 sh -c "echo \$PATH | tr ':' '\n'"
/home/circleci/.local/bin
/home/circleci/bin
/go/bin
/usr/local/go/bin
/usr/local/sbin
/usr/local/bin
/usr/sbin
/usr/bin
/sbin
/bin
✗ docker run -it cimg/go:1.19 sh -c "echo \$PATH | tr ':' '\n'"
/home/circleci/go/bin
/usr/local/go/bin
/home/circleci/bin
/home/circleci/.local/bin
/usr/local/sbin
/usr/local/bin
/usr/sbin
/usr/bin
/sbin
/bin

@nitrocode nitrocode requested a review from a team as a code owner November 13, 2022 14:53
@nitrocode nitrocode changed the title Bump to atlantis-base:2022.11.13 Bump to atlantis-base:2022.11.13 and use cimg/go:1.19 Nov 13, 2022
jamengual
jamengual approved these changes Nov 13, 2022
View reviewed changes
Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@nitrocode nitrocode merged commit 6f7ee2e into master Nov 13, 2022
@nitrocode nitrocode deleted the atlantis-base-2022.11.13 branch November 13, 2022 20:51
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
@nitrocode @krrrr38
Bump to atlantis-base:2022.11.13 and use cimg/go:1.19 (runatlantis#2673)
0ded969 
* Bump to atlantis-base:2022.11.13

* Use cimg/go back image

* Use correct path of cimg/go binary dir

* e2e: use /usr/bin

* e2e: add set -e

* circleci: use testing-env:2022.11.13

* e2e: use /home/circleci/go/bin

* e2e: revert to testing-env:2021.08.31 image
@nitrocode nitrocode added this to the 0.21.0 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocode @jamengual