Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e image and testing fixes #2672

Merged
merged 3 commits into from
Nov 13, 2022
Merged

e2e image and testing fixes #2672

merged 3 commits into from
Nov 13, 2022

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Nov 13, 2022 •
edited
Loading

what

  • Remove go get downloading of golang.org/x/tools/cmd/goimports from testing/Dockerfile
  • Add trigger for testing-env-image workflow if the testing/** dir is modified in PR
  • Revert cimg/go back to circleci/golang image
  • hadolint fixes

why

  • Using go get caused the testing image build failure.
  • I saw the error with testing-env-image after merging the PR instead of before. THe new trigger will show the error prior to the merge.
  • For some reason the new cimg/go image cannot download the terraform version and results in an e2e error initializing terraform: terraform not found in $PATH
  • Fixed a couple (not all) linting errors shown by hadolint for best practices.

references

@nitrocode nitrocode requested a review from a team as a code owner November 13, 2022 14:17
@nitrocode nitrocode changed the title Go 1.19 fix end to end e2e image and testing fixes Nov 13, 2022
@nitrocode nitrocode merged commit 62719ee into runatlantis:master Nov 13, 2022
@nitrocode nitrocode deleted the go-1.19-fix-end-to-end branch November 13, 2022 19:11
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
@nitrocode @krrrr38
e2e image and testing fixes (runatlantis#2672)
11a8670 
* build testing-env-image in relevant PRs

* hadolint testing/Dockerfile and rm go get

* revert cimg/go back to circleci/golang image
@nitrocode nitrocode added this to the 0.21.0 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nitrocode @chenrui333