Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename default branch to main #2662

Merged
merged 4 commits into from
Nov 14, 2022
Merged

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Nov 11, 2022

what

  • Rename default branch to main

why

  • Best practices of naming

references

testing

$ docker buildx create --use
$ docker buildx build --iidfile /tmp/docker-build-push-UlLBPW/iidfile --platform linux/arm64/v8,linux/amd64,linux/arm/v7 --tag ghcr.io/runatlantis/atlantis-base:2022.11.11 --tag ghcr.io/runatlantis/atlantis-base:latest --metadata-file /tmp/docker-build-push-UlLBPW/metadata-file docker-base
 => [linux/arm64 4/4] RUN [ ! -e /etc/nsswitch.conf ] && echo 'hosts: files dns' > /etc/nsswitch.conf                                                                                      0.1s
 => [linux/arm/v7 4/4] RUN [ ! -e /etc/nsswitch.conf ] && echo 'hosts: files dns' > /etc/nsswitch.conf                                                                                     0.1s
 => [linux/amd64 4/4] RUN [ ! -e /etc/nsswitch.conf ] && echo 'hosts: files dns' > /etc/nsswitch.conf
make test
$ make test
?   	github.com/runatlantis/atlantis	[no test files]
ok  	github.com/runatlantis/atlantis/cmd	0.514s
ok  	github.com/runatlantis/atlantis/server	2.121s
ok  	github.com/runatlantis/atlantis/server/controllers	0.786s
ok  	github.com/runatlantis/atlantis/server/controllers/events	0.629s
?   	github.com/runatlantis/atlantis/server/controllers/templates	[no test files]
ok  	github.com/runatlantis/atlantis/server/controllers/websocket	0.228s
ok  	github.com/runatlantis/atlantis/server/core/config	(cached)
ok  	github.com/runatlantis/atlantis/server/core/config/raw	(cached)
ok  	github.com/runatlantis/atlantis/server/core/config/valid	(cached)
ok  	github.com/runatlantis/atlantis/server/core/db	(cached)
ok  	github.com/runatlantis/atlantis/server/core/locking	(cached)
ok  	github.com/runatlantis/atlantis/server/core/redis	(cached)
ok  	github.com/runatlantis/atlantis/server/core/runtime	6.835s
ok  	github.com/runatlantis/atlantis/server/core/runtime/cache	(cached)
ok  	github.com/runatlantis/atlantis/server/core/runtime/common	(cached)
ok  	github.com/runatlantis/atlantis/server/core/runtime/models	(cached)
ok  	github.com/runatlantis/atlantis/server/core/runtime/policy	(cached)
ok  	github.com/runatlantis/atlantis/server/core/terraform	6.671s
ok  	github.com/runatlantis/atlantis/server/events	21.858s
ok  	github.com/runatlantis/atlantis/server/events/command	(cached)
?   	github.com/runatlantis/atlantis/server/events/matchers	[no test files]
ok  	github.com/runatlantis/atlantis/server/events/models	(cached)
?   	github.com/runatlantis/atlantis/server/events/models/fixtures	[no test files]
?   	github.com/runatlantis/atlantis/server/events/terraform/ansi	[no test files]
ok  	github.com/runatlantis/atlantis/server/events/vcs	(cached)
ok  	github.com/runatlantis/atlantis/server/events/vcs/bitbucketcloud	(cached)
ok  	github.com/runatlantis/atlantis/server/events/vcs/bitbucketserver	(cached)
ok  	github.com/runatlantis/atlantis/server/events/vcs/common	(cached)
?   	github.com/runatlantis/atlantis/server/events/vcs/fixtures	[no test files]
ok  	github.com/runatlantis/atlantis/server/events/webhooks	(cached)
ok  	github.com/runatlantis/atlantis/server/jobs	(cached)
ok  	github.com/runatlantis/atlantis/server/logging	(cached)
?   	github.com/runatlantis/atlantis/server/metrics	[no test files]
ok  	github.com/runatlantis/atlantis/server/recovery	(cached) [no tests to run]
?   	github.com/runatlantis/atlantis/server/scheduled	[no test files]
?   	github.com/runatlantis/atlantis/testdrive	[no test files]

@nitrocode nitrocode requested a review from a team as a code owner November 11, 2022 04:30
Copy link
Contributor

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitrocode nitrocode marked this pull request as draft November 11, 2022 05:17
@nitrocode nitrocode marked this pull request as ready for review November 11, 2022 16:27
@nitrocode nitrocode merged commit d85662c into runatlantis:main Nov 14, 2022
@nitrocode nitrocode deleted the rename-to-main branch November 14, 2022 17:28
krrrr38 pushed a commit to krrrr38/atlantis that referenced this pull request Dec 16, 2022
* Rename default branch to main

* Bump git, curl, and openssl packages
@nitrocode nitrocode added this to the 0.21.0 milestone Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants