Revert "[fix] Ignore commit checks for atlantis apply on Github (#2311)" #2388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tlantis#2311)" This reverts commit a3db712.
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
…tlantis#2311)" (runatlantis#2388) * Revert "[fix] Ignore commit checks for atlantis apply on Github (runatlantis#2311)" This reverts commit a3db712.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts a change that accidentally introduced regression described by #2112, where an unmergeable GitHub PR can be applied when
apply_requirements: [mergeable]is set.Disclaimer: This PR doesn't implement additional features that cover more use cases, but only tries to resolve the regression.
Notes
This reverts commit a3db712.
Revert "[fix] Ignore commit checks for atlantis apply on Github (#2311)"