fix: Log streaming broken with TFE local execution mode #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @casperbiering for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using TFE just for storing states and not for remote execution mode, seeing the streaming plan logs in Atlantis is currently broken.
It's is due to when setting
--tfe-token(orATLANTIS_TFE_TOKENenv) then theNoopProjectOutputHandleris used instead ofNewAsyncProjectCommandOutputHandler.This PR implements a new option
--tfe-local-execution-modeso Atlantis will keep using theNewAsyncProjectCommandOutputHandler.This PR might be the fix for #2111 and #2129