workflows: build image in parallel #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The git push does not release the image for all 3 platforms but overwrites them in the GitHub container registry. |
|
@chenrui333 FYI |
chenrui333
approved these changes
Jul 5, 2022
|
This is a good improvement. Thanks @waeltken! |
|
need to also apply the matrix builds into other workflows as well. |
chenrui333
changed the title
Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
added a commit
that referenced
this pull request
Jul 8, 2022
This reverts commit 8c0ca6b.
chenrui333
added a commit
that referenced
this pull request
Jul 8, 2022
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
* Enable GitHub matrix strategy to run builds in parallel * apply matrix build for the other images Signed-off-by: Rui Chen <rui@chenrui.dev> Co-authored-by: Rui Chen <rui@chenrui.dev>
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
…lantis#2372) This reverts commit 8c0ca6b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the build job for the docker image to use the matrix jobs feature, speeding up the image creation.
https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs