docker: make multi-platform atlantis image #1943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamengual
approved these changes
Dec 16, 2021
|
looks good, gonna pull the testing-env update per this commit to fix PR build issue. https://github.com/runatlantis/atlantis/pkgs/container/atlantis/11917973?tag=dev |
chenrui333
added a commit
that referenced
this pull request
Dec 17, 2021
relates to #1943 Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
force-pushed
the
docker-multi-platform
branch
from
1dc2aee
to
266e04d
Compare
Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
force-pushed
the
docker-multi-platform
branch
from
50b63cc
to
bbb621f
Compare
chenrui333
changed the title
This reverts commit 266e04d.
chenrui333
added a commit
that referenced
this pull request
Dec 30, 2021
…-test-job * 'master' of github.com:runatlantis/atlantis: (79 commits) release: 0.18.0 (#1965) feat: streaming terraform logs in real-time (#1937) build(deps): bump github.com/hashicorp/go-getter from 1.5.9 to 1.5.10 (#1961) docs: update website links (#1964) docs: clarify example for `--azuredevops-token` flag (#1712) docs: typo in heading level (#1960) fix: fallback to default TF version in apply step (#1931) feat: add GitHub team allowlist configuration option (#1694) Add in Dockerfile support for last Terraform 1.0.x version in AVAILABLE_TERRAFORM_VERSIONS (#1957) build(deps): bump github.com/spf13/viper from 1.10.0 to 1.10.1 (#1956) deps: terraform 1.1.2 (#1952) release: 0.17.6 (#1947) docker: make multi-platform atlantis image (#1943) docker(testing): fix arch ref for `linux/arm/v7` docker(testing): updating image build process docs: fix policy check documentation examples (#1945) build: make multi-platform image for testing-env atlantis-base: fix context atalntis-base: update platforms and path trigger atlantis-base: update platforms ...
|
I noticed the Docker image build job have failed since this change, so I've made a PR which I think fixes it here: #1975. |
chenrui333
pushed a commit
that referenced
this pull request
Jan 5, 2022
…es (#1975) #1943 changed the way Docker images were built in GitHub Actions so multi-architecture Docker images now are built, but it unfortunately included a bug which means it hasn't worked yet on any released version of Atlantis. The problem is the change expected environment variables to be replaced in the regular YAML code instead of just the commands which are run. This attempts to fix that by instead using the template language available to access the same environment variable. This is based on the example provided in the documentation here: https://docs.github.com/en/actions/learn-github-actions/environment-variables.
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
relates to runatlantis#1943 Signed-off-by: Rui Chen <rui@chenrui.dev>
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
* docker: multi-platform image for atlantis * workflow: update for multi platform image builds Signed-off-by: Rui Chen <rui@chenrui.dev> * update branch trigger for testing dev image Signed-off-by: Rui Chen <rui@chenrui.dev> * revert to use testing-env:2021.08.31 Signed-off-by: Rui Chen <rui@chenrui.dev> * Revert "update branch trigger for testing dev image" This reverts commit 266e04d.
krrrr38
pushed a commit
to krrrr38/atlantis
that referenced
this pull request
Dec 16, 2022
…es (runatlantis#1975) runatlantis#1943 changed the way Docker images were built in GitHub Actions so multi-architecture Docker images now are built, but it unfortunately included a bug which means it hasn't worked yet on any released version of Atlantis. The problem is the change expected environment variables to be replaced in the regular YAML code instead of just the commands which are run. This attempts to fix that by instead using the template language available to access the same environment variable. This is based on the example provided in the documentation here: https://docs.github.com/en/actions/learn-github-actions/environment-variables.
chenrui333
added
docker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.