Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make policy checks its own apply requirement. (#61) #1499

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

nishkrishnan
Copy link
Contributor

This makes policy checking a better experience for the customer and operator:

  • Mergeability is decoupled from policy checking. There are a bunch of issues I've seen in the issues about mergeability not working for their usecase.
  • The message is updated to be explicit about addressing failed policies.
  • policy checking now failures only block the project that it failed for and not every project in the PR.
  • The apply requirement gets loaded when a server has policy checking enabled

@nishkrishnan nishkrishnan requested a review from a team as a code owner April 12, 2021 18:09
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #1499 (0c75cc3) into master (921ebbc) will decrease coverage by 0.15%.
The diff coverage is 59.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1499      +/-   ##
==========================================
- Coverage   70.23%   70.08%   -0.16%     
==========================================
  Files          94       94              
  Lines        6441     6485      +44     
==========================================
+ Hits         4524     4545      +21     
- Misses       1533     1554      +21     
- Partials      384      386       +2     
Impacted Files Coverage Δ
server/events/apply_command_runner.go 71.60% <ø> (-2.26%) ⬇️
server/events/comment_parser.go 94.20% <ø> (ø)
server/events/models/models.go 74.10% <ø> (ø)
server/events/project_command_runner.go 46.66% <0.00%> (-0.87%) ⬇️
server/events/yaml/raw/global_cfg.go 0.00% <0.00%> (ø)
server/events/plan_command_runner.go 40.94% <50.00%> (+0.14%) ⬆️
server/events/yaml/valid/global_cfg.go 85.45% <52.94%> (-4.16%) ⬇️
server/events/command_runner.go 63.07% <78.94%> (-0.86%) ⬇️
server/events/project_command_context_builder.go 97.54% <100.00%> (+2.85%) ⬆️
server/server.go 65.14% <100.00%> (+0.56%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 921ebbc...0c75cc3. Read the comment docs.

Copy link
Contributor

@msarvar msarvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LBTM 🎉

@nishkrishnan nishkrishnan merged commit df106de into runatlantis:master Apr 13, 2021
@mikecutalo mikecutalo deleted the nish/add-policy-apply-req branch June 8, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants