Further parse Gitlab MergeRequest Update events #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any update on this MR |
|
@cucxabong can you update your PR and we will do a review, thanks |
jamengual
added
waiting-on-response
|
HI @jamengual I think I'm done with this MR, I'm not sure about which part need to be update? |
jamengual
added
waiting-on-review
|
@cucxabong sorry, I was updating a bunch of PR and copy and pasted, we will review ASAP. |
|
@cucxabong thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR further parses Gitlab MergeRequest Update event to see if Atlantis should handle the update or just ignoring it. With current implementation of gitlab sdk used in Atlantis. We could ignore events such as assignee/description/title/labels changing