Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub app #1088

Merged
merged 8 commits into from
Jun 19, 2020
Merged

GitHub app #1088

merged 8 commits into from
Jun 19, 2020

Commits on Jun 4, 2020

  1. Play around with github app credentials

    @unRob
    unRob authored and Roberto Hidalgo committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    199cdfe View commit details
    Browse the repository at this point in the history

  2. Upgrade to github/v31 for CompleteAppManifest 

    split fixtures out elsewhere, add working dir test
    @unRob
    unRob authored and Roberto Hidalgo committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    227ce9c View commit details
    Browse the repository at this point in the history

  3. Test against a live repo, fix accordingly 

    more docs, add installation step
    @unRob
    unRob authored and Roberto Hidalgo committed Jun 4, 2020
    Configuration menu
    Copy the full SHA
    011d3f8 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. enable webhook url, listen to issue_comment event

    @unRob
    unRob committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    dffba36 View commit details
    Browse the repository at this point in the history

  2. listen to pull_request_review*, docs on webhooks

    @unRob
    unRob committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    2509240 View commit details
    Browse the repository at this point in the history

  3. Error out instead of panicking when passed a bad keyfile

    @unRob
    unRob committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    13ebeee View commit details
    Browse the repository at this point in the history

  4. make fragments lowercase

    @unRob
    unRob committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    2b74dc9 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. Refactoring to github app code 

    - rename gh-app-key to gh-app-key-file for clarity
- change git credentials writer to append a line if there is an existing
.git-credentials file and in the case of the github app to replace the
old github app line
- removed automatically setting --write-git-creds to true when using a
github app and instead requiring this is set specifically
    @lkysow
    lkysow committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    875abf1 View commit details
    Browse the repository at this point in the history