Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcs/github_client: add logging around github API calls #1042

Merged
merged 4 commits into from
Jun 1, 2020

Conversation

cket
Copy link
Contributor

@cket cket commented May 21, 2020

This PR adds debug level logging to indicate when Atlantis is making github API calls. This will be helpful when we approach GH rate limits and want some visibility into when + why calls are made.

@codecov
Copy link

codecov bot commented May 21, 2020

Codecov Report

Merging #1042 into master will increase coverage by 0.01%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1042      +/-   ##
==========================================
+ Coverage   71.96%   71.98%   +0.01%     
==========================================
  Files          65       65              
  Lines        5429     5436       +7     
==========================================
+ Hits         3907     3913       +6     
- Misses       1215     1216       +1     
  Partials      307      307              
Impacted Files Coverage Δ
server/server.go 63.77% <0.00%> (ø)
server/events/vcs/github_client.go 80.89% <87.50%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39c5ad8...3d0bb64. Read the comment docs.

server/events/vcs/github_client_internal_test.go Outdated Show resolved Hide resolved
server/events/vcs/github_client.go Outdated Show resolved Hide resolved
@lkysow lkysow added the waiting-on-response Waiting for a response from the user label May 25, 2020
@cket cket requested a review from lkysow May 29, 2020 20:01
Copy link
Member

@lkysow lkysow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@lkysow lkysow merged commit 88e397e into runatlantis:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-response Waiting for a response from the user
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants