Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitLab Enterprise Edition Comment Formatting #315

Closed
lkysow opened this issue Oct 12, 2018 · 4 comments
Closed

GitLab Enterprise Edition Comment Formatting #315

lkysow opened this issue Oct 12, 2018 · 4 comments
Labels
bug Something isn't working provider/gitlab

Comments

@lkysow
Copy link
Member

lkysow commented Oct 12, 2018

User report that code isn't formatted inside the expandable details block.

Version: 10.8.4-ee f80a528
@mechastorm
Copy link

I can verify the same issue is happening for us in Gitlab Enterprise integrations. Its causing Atlantis to be unusable and forcing us to downgrade to v0.4.8 has a temporary measure until this is fixed.

@kent-b
Copy link
Contributor

kent-b commented Nov 20, 2018 •
edited
Loading

This affects Gitlab versions < 11.1, which use the Redcarpet Markdown engine.
According to the docs, "You can work around this by using HTML, for example you can use <pre><code> tags instead of code fences."

Versions >= 11.1 use an extended version of the CommonMark library, which should format the details block correctly.

https://docs.gitlab.com/ee/user/markdown.html#details-and-summary

@lkysow
Copy link
Member Author

lkysow commented Nov 20, 2018

If you use <pre> you don't get the syntax highlighting though.

@lkysow lkysow added the bug Something isn't working label Nov 29, 2018
@lkysow lkysow mentioned this issue Nov 29, 2018
Merged
lkysow added a commit that referenced this issue Nov 29, 2018
@lkysow
Disable markdown folding on gitlab < 11.1.
ba04564 
On startup, make a call to the /version endpoint of Gitlab to get which
version we're running. Then use that version to determine whether we
should use the markdown folding syntax where the code is expandable.
Versions of Gitlab < 11.1 don't support the "Common Mark" markdown
format.

Fixes #315
@lkysow
Copy link
Member Author

lkysow commented Nov 30, 2018

@kent-b @solidnerd @mechastorm the fix will be in v0.4.12 which should come out any minute now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working provider/gitlab
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lkysow @mechastorm @kent-b @nitrocode