-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automerge happens on an apply of 0 projects #1674
Comments
Is it possible that when you upgraded, atlantis' boltdb instance got deleted? Atlantis stores pull request specific states inside its boltdb instance, so one explanation could be that the db was wiped during upgrade. |
@msarvar Absolutely. I run atlantis as an AWS fargate task, so the new task had a new container. I'm fully aware of that. I just wonder why atlantis would allow an apply to be run on a Pull Request that did not have a valid plan and had changes. |
FYI, my only workaround for this is that whenever I refresh atlantis is to run a script that comments |
@msarvar if only I could add a waiting-on-response-response tag |
@grimm26 Sorry for the wait, but looks like other similar issues were marked already. So I will update the tags accordingly. |
is this still an issue with |
Sometimes I see this even on the latest version, but I have no idea how to repro, it seems totally ittermitent. |
I just upgraded to atlantis 0.17.1 from 0.17.0 and I'm using it with a GitHub Enterprise instance. When I did the atlantis upgrade, there were a couple of pull requests that were planned and approved but had not yet been applied. Someone ran an
atlantis apply
on them and they applied and automerged. The apply was for 0 projects because there was no plan in play, but it still called that apply successful and then automerged. The log showed:I tried to reproduce this by creating a new PR, planning and approving it, then unlocking it from the atlantis UI and then trying an apply. It still did the 0 projects apply, but it did not automerge.
When I looked at the log, it shows "
So I assume there must be a saved state in the second case to show that the plan was discarded. Why does the first one go ahead with applying a merging when it applied 0 projects and there was obviously no plan to begin with?
The text was updated successfully, but these errors were encountered: