atlantis apply after discarded lock results in "Ran apply for 0 projects"

[etherops]

Issue Details:

• atlantis_version = 0.10.2
• docker image = runatlantis/atlantis:v0.10.2
• terraform version = 0.11.14
• VCS = github
• Configuration:

bash-5.0# env   | grep ATLANTIS  | sort | grep -v "PORT\|HOST\|URL\|GH\|WHITELIST\|SLACK"
ATLANTIS_AUTOMERGE=1
ATLANTIS_CONFIG=/home/atlantis/atlantis.yaml
ATLANTIS_DATA_DIR=/atlantis
ATLANTIS_DEFAULT_TF_VERSION=0.11.14
ATLANTIS_LOG_LEVEL=debug
ATLANTIS_REPO_CONFIG_JSON={"repos":[{"id":"/.*/","apply_requirements":["mergeable","approved"],"workflow":"terraform"}],"workflows":{"terraform":{"apply":{"steps":[{"run":"terraform0.11.14 apply -no-color $PLANFILE && slack_prodchanges"}]}}}}

Summary

When a user discards the lock for a PR va the atlantis UI, atlantis discards the lock and comments as such on the target PR. However, if the users then types in atlantis apply without re-running plan, atlantis will not apply for any projects, but will say it successfully ran the apply for "0" projects. We have automerge on so this is doubly problematic and usually goes unnoticed by the inattentive-to-detail users!

Repro Steps

• User opens a github PR
• Atlantis autoplans the project
• User discards lock via the atlantis UI
• Atlantis discards the lock with comments: "To apply this plan you must run plan again."
• User ignores comment and runs atlantis apply in the PR anyways atlantis apply
• Atlantis applies and appears to have success, but actually silently "fails" in that apply is run for 0 Projects "Ran Apply for 0 projects:"
• Atlantis automerges the PR since automerge is configured
• Unattentive user does not notice that the apply was for 0 projects and moves along, believing apply happened when in reality it did not!
• Subsequent PR to same project reveals hidden, unapplied changes!

Attachments

Below please find a screen shot of an example PR in action.

[jlm0x013]

I'm interpreting the main error as 'Atlantis applies and appears to have success, but actually silently "fails" in that apply is run for 0 Projects "Ran Apply for 0 projects:"'. That is, if Atlantis fails the merge, then people are aware that there has been an error; and github will not close the associated PR.

[jamengual]

is this still an issue with v0.19.8?

[etherops]

Hi @jamengual - feel free to close this issue. I am not longer working in the position I was where I reported the issue and am not able to validate/repro at this point. Thanks!