Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store plan output in external source such as S3 and post link in the PR comment instead of full output #121

Open
colinjfw opened this issue May 3, 2018 · 13 comments
Labels
feature New functionality/enhancement

Comments

@colinjfw
Copy link

colinjfw commented May 3, 2018

It would be great to have an option in atlantis to store the plan output on the atlantis server. The github comment could link to a page with just the plain text view of the output. Benefits to this:

The github comment could link to the atlantis server where the output would be stored.

@colinjfw
Copy link
Author

colinjfw commented May 3, 2018

I would be willing to take this on, looking at the code so far I think I could handle this!

@lkysow
Copy link
Member

lkysow commented May 10, 2018

Sorry for the delay responding! I think this is a good idea because in the future I want Atlantis to have its own UI for viewing plans and their states and so eventually we'll link to that UI.

@colinjfw
Copy link
Author

@lkysow I won't be able to take this on for another few weeks. Definitely interested in taking it on though, I will keep this up to date but if someone else grab's this ticket no worries from me.

@bewie
Copy link
Contributor

bewie commented Sep 17, 2018

Hi,
Do you know if this ticket is still relevant; because since I use vault provider with terraform, I have lot of issues with sensitive data in output. And terrahelp cannot catch it.
I think the only stable solution should be to store the output on Atlantis server (or S3).

@lkysow
Copy link
Member

lkysow commented Sep 17, 2018

Yes I think this ticket is still relevant, especially for your use case.

@lkysow lkysow added the feature New functionality/enhancement label Apr 4, 2019
@JoshiiSinfield
Copy link
Contributor

Hi,
I have a similar use case. I'd like the ability to store plan outputs in S3 or DynamoDB.

We run Atlantis in Fargate, and leave it on 24/7 but we'd like to fire it up only when we receive a request to the webhook (could be done by scaling or by a lambda target on ALB).

But in order to make this feasible/match the current functionality we'd need to store the plan output NOT on the atlantis server.

@lkysow Would you like a different issue raising for S3/DynamoDB? keep this one as storing on server?

Cheers,
Josh

@lkysow
Copy link
Member

lkysow commented Jan 10, 2020

@JoshiiSinfield this has already been discussed in #265 which was closed as won't do. See my comment: #265 (comment)

@JoshiiSinfield
Copy link
Contributor

@lkysow sorry, my brief search failed me!

I'd be willing to put some time in if you'd be able to direct me where to start/with a plan of action, because as you know I'm still learning go!

It would certainly be a cost saver for us. Along with a great opportunity to contribute for myself!

@natalysheinin
Copy link

+1 for running atlantis serverless with the option for remote plans to be in GCS (and/or S3).

@christopher-dG
Copy link

Bump: when huge plans get split across 10 comments, I would love to be able to click a link to see the full, coloured output.

@jhebert-coursera
Copy link

I guess I'll add another comment in support of this request, although in our case I think S3 would be ideal. We have many configured Atlantis projects, some of which are quite large, and a module change that impacts numerous projects is very difficult to read as Github comments. In the extreme case, we might have 25 projects being planned concurrently, each with thousands of lines of output, requiring a pretty tedious amount of scrolling and clicking "Show Output" as Github collapses things.

That being said, Atlantis has been a game-changer for us, so thanks for all of the work on this!

@nitrocode
Copy link
Member

Related issue #936

Technically we do have a way of seeing the plan stored on the server via websockets using the plan/apply "Details" link at the bottom of a Github PR. The plan unfortunately is still ephemeral. If you restart atlantis, you can no longer see the plan outputs.

It would be great to store the plan in S3 or some external store instead. PRs are always welcome.

@nitrocode nitrocode changed the title Plan output stored on the atlantis server Store plan output in external source such as S3 and post link in the PR comment instead of full output Feb 25, 2023
@jamengual
Copy link
Contributor

there might be enough information here #2157

meringu pushed a commit to meringu/atlantis that referenced this issue May 29, 2023
…ine Fixes runatlantis#121 (runatlantis#132)

* plan and apply terraform commands error outputs printed after a new line

* Update terraform_client.go

* returning error outputs as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement
Projects
None yet
Development

No branches or pull requests

9 participants