Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and extend keyword parsing #238

Merged
merged 8 commits into from
Jan 17, 2023
Merged

Fix and extend keyword parsing #238

merged 8 commits into from
Jan 17, 2023

Conversation

Zeyuzhao
Copy link
Contributor

@Zeyuzhao Zeyuzhao commented Jan 16, 2023 •
edited by jerryjliu
Loading

Originally, extract_keywords_given_response would parse "KEYWORDS: foo, bar, foobar" as ["bar", "foobar"].

This PR

  • fixes the missing first token issue
  • adds a new start_token parameter (by default, KEYWORDS:)
  • adds tests for parsing with start token.

TODO:

  • Associate start_token with prompts, instead of hardcoding it.

@jerryjliu jerryjliu merged commit ae6d2c2 into run-llama:main Jan 17, 2023
viveksilimkhan1 pushed a commit to viveksilimkhan1/llama_index that referenced this pull request Oct 30, 2023
@rmitsch
Bump LangChain (also in setup.cfg) (run-llama#238)
ca19b3f 
* Bump LangChain to 0.0.249.

* Bump LangChain in setup.cfg.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeyuzhao @jerryjliu